Fix LLM EntityLinker task factory typo #13840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the factory string for the EntityLinker to "llm_entitylinker" so it works, as per https://github.com/explosion/spacy-llm/blob/main/spacy_llm/tasks/__init__.py#L33. This appears to be the only place it is documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the factory string for the EntityLinker to "llm_entitylinker" from "llm_entity_linker" so that it works, as per https://github.com/explosion/spacy-llm/blob/main/spacy_llm/tasks/__init__.py#L33.
This appears to be the only place it is documented.
Types of change
Documentation change to reflect the API as currently implemented.
Checklist
- [ ] I ran the tests, and all new and existing tests passed.